Skip to content

Repo sync for protected CLA branch#3279

Merged
colin-home merged 2 commits into
masterfrom
master637636092850540086
Aug 5, 2021
Merged

Repo sync for protected CLA branch#3279
colin-home merged 2 commits into
masterfrom
master637636092850540086

Conversation

@opbld16

@opbld16 opbld16 commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

The pull request is created from master637636092850540086 to master to fix git push error for protected CLA branch

Taojunshen and others added 2 commits August 4, 2021 01:38
@Taojunshen @TylerMSFT @ystamant
8/3/2021 AM Publish (#3690)
7c6c0cd 
* fix code sample (#3676)

* fix code sample

* acrolinx

Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com>

* Address 3269 typo in warning number (#3680)

* Fixed typo: evalution --> evaluation

* Bulk Fix - Sentence form for all alt text (#3683)

* Updated C/C++ workload name

The workload for C/C++ development in VS Build Tools 2019 installer is called 'Desktop development with C++'.

* Split out docs by version

Add VS2017-specific instructions.

* Add 16.11 Compiler Warnings C5247 and C5248 (#3689)

* Add C5247 and C5248

* Fix link typos

* Updates per Xiang Fan review

* More wordsmithage

* More fix per X.F.

Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com>
Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com>
Co-authored-by: Colin Robertson <corob@microsoft.com>
Co-authored-by: ystamant <49958001+ystamant@users.noreply.github.com>
Co-authored-by: Andrew Shymanel <88244804+ainrd@users.noreply.github.com>
@opbld16
Merging changes synced from https://github.com/MicrosoftDocs/cpp-docs-pr
bfad80a 
 (branch live)
@opbld16 opbld16 added the CLA label Aug 3, 2021
@PRMerger17

PRMerger17 commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

@opbld16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver requested a review from colin-home August 3, 2021 18:34
@ShannonLeavitt

ShannonLeavitt commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

See MicrosoftDocs/visualstudio-docs#6906 (comment) for comments that relate do this.

@colin-home

colin-home commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

@ShannonLeavitt
I don't think the issue in the visualstudio-docs-pr repo applies here. We don't have automation that automatically merges updates from cpp-docs-pr into cpp-docs. We've always merged these by hand. The automation going the other way also requires manual intervention. We rarely get more than one submission to the public repo in a day, so I don't think we've had issues with squashing the auto-generated PRs yet. The other issue about PRs that qualify for auto merge not being auto merged hasn't been tested yet, so we might have the same problem Gordon describes.

@colin-home colin-home merged commit 569a751 into master Aug 5, 2021
@colin-home colin-home deleted the master637636092850540086 branch August 5, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colin-home colin-home colin-home approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@colin-home colin-home

Labels

Change sent to author CLA cpp-diagnostics/tech visual-cpp/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@opbld16 @PRMerger17 @ShannonLeavitt @colin-home @Taojunshen