Update template-specialization-cpp.md#3223
Merged
Merged
Conversation
Contributor
|
@Jaiganeshkumaran : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Switch to stack-based objects.
Contributor
|
@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
colin-home
approved these changes
Jul 9, 2021
colin-home
left a comment
colin-home
left a comment
Contributor
There was a problem hiding this comment.
@Jaiganeshkumaran Thanks for the update and for bringing the leaky code to my attention. Rather than use heap objects, I edited your changes to use Modern stack-based style, so the objects are deleted when they go out of scope. I also updated the template parameters to match the current C++ string literal definitions. This code would have remained broken without your submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the delete statement for showcasing good practice.