Skip to content

Improve errno Constants page#3049

Merged
colin-home merged 4 commits into
MicrosoftDocs:masterfrom
ccawley2011:patch-1
Apr 26, 2021
Merged

Improve errno Constants page#3049
colin-home merged 4 commits into
MicrosoftDocs:masterfrom
ccawley2011:patch-1

Conversation

@ccawley2011

@ccawley2011 ccawley2011 commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

The table has been combined with the one from the errno, _doserrno, _sys_errlist, and _sys_nerr page, and the values for the POSIX error codes have been added.

@ghost

ghost commented Mar 22, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@PRMerger16

PRMerger16 commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

@ccawley2011 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16 PRMerger16 requested a review from TylerMSFT March 23, 2021 11:39
@ktoliver ktoliver added the aq-pr-triaged Tracking label for the PR review team label Mar 23, 2021
@TylerMSFT

TylerMSFT commented Mar 25, 2021

Copy link
Copy Markdown
Collaborator

Hi @ccawley2011, thank you for taking time to improve the docs. I'll review this but am in the middle of getting ready for a release. I will come back to this, but it will be a bit. Didn't want you to think this is forgotten.

@colin-home

colin-home commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

@ccawley2011 @TylerMSFT
This looks like a fine addition. There are a couple of style issues I'd fix. I'd recommend using alphabetical order on the constant names, rather than ordering them by their values, for ease of lookup. I'd also recommend switching to code style for the constants, for errno itself, flags like _O_CREAT, and for function names, such as _open. Also, tables are easier to read if they have spaces between the pipe characters and cell contents, and it looks like the last pipe character in _STRUNCATE in the first table is missing. It doesn't affect rendering, but it's a good style practice, especially if you're going to sort rows.

@PRMerger17

PRMerger17 commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

@ccawley2011 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Merge and fix style issues.
c250bc8 
Update headers to include all the constants for F1 and Help.
Merge style changes from main branch.
Acrolinx pass.
@PRMerger19

PRMerger19 commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

colin-home
colin-home approved these changes Apr 26, 2021
View reviewed changes

@colin-home colin-home left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccawley2011 It's taken a long time to get back to this. I've fixed some style issues and made other fixes to make our build system happy. Thanks for your contribution, we appreciate it.

@colin-home colin-home merged commit f8d1915 into MicrosoftDocs:master Apr 26, 2021
@ccawley2011 ccawley2011 deleted the patch-1 branch April 26, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerMSFT TylerMSFT Awaiting requested review from TylerMSFT

1 more reviewer

@colin-home colin-home colin-home approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TylerMSFT TylerMSFT

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-ucrt/tech do-not-merge visual-cpp/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ccawley2011 @PRMerger16 @TylerMSFT @colin-home @PRMerger17 @PRMerger19 @ktoliver