string -> stringBuffer on strcpy_s... page#2993
Merged
Merged
Conversation
When this page is viewed on the microsoft documentation page (https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/strcpy-s-wcscpy-s-mbscpy-s?view=msvc-160), the variable "string" is highlighted in code as if it were a type, and an array of type "wchar_t string" were being allocated. This is confusing - the "string" variable should be highlighted as if it were a variable. I've renamed the "string" variable to "stringBuffer" to ensure it highlights correctly without changing the meaning of the code. However, I'm not familiar with this repository or the coding conventions used.
Contributor
|
@cartwrightluke : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
TylerMSFT
approved these changes
Feb 26, 2021
TylerMSFT
left a comment
TylerMSFT
left a comment
Collaborator
There was a problem hiding this comment.
@cartwrightluke, thank you for improving the docs. I've approved this PR.
We are having some trouble with our publishing pipeline at the moment, so it may be into next week before your changes show up in the live tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this page is viewed on the microsoft documentation page (https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/strcpy-s-wcscpy-s-mbscpy-s?view=msvc-160), the variable "string" is highlighted in code as if it were a type, and an array of type "wchar_t string" were being allocated. This is confusing - the "string" variable should be highlighted as if it were a variable.
I've renamed the "string" variable to "stringBuffer" to ensure it highlights correctly without changing the meaning of the code. However, I'm not familiar with this repository or the coding conventions used.