Explicitly convert streampos to streamoff#2587
Merged
Merged
Conversation
The expression (cout << y) works as described only if no shift operator of streampos into ostream is defined. That operator may be defined by user code and the result may be different.
Explicitly convert streampos to streamoff.
Contributor
|
@yecril71pl : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
TylerMSFT
approved these changes
Nov 9, 2020
TylerMSFT
left a comment
TylerMSFT
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching the second one. The first change is already live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streampostostreamoff.'\n'instead ofendl.