Skip to content

Clarify using gmtime with strftime %z %Z#2306

Merged
TylerMSFT merged 2 commits into
MicrosoftDocs:masterfrom
amyw-msft:patch-15
Jul 14, 2020
Merged

Clarify using gmtime with strftime %z %Z#2306
TylerMSFT merged 2 commits into
MicrosoftDocs:masterfrom
amyw-msft:patch-15

Conversation

@amyw-msft

Copy link
Copy Markdown
Member

Formatting the tm struct returned from gmtime with strftime %z or %Z will yield unexpected results. We should have a note in our strftime documentation about this since other implementations have a different behavior (the tm struct is extended to include time zone name and offset).

Formatting the tm struct returned from gmtime with strftime %z or %Z will yield unexpected results. We should have a note in our strftime documentation about this since other implementations have a different behavior (the tm struct is extended to include time zone name and offset).
@PRMerger12

Copy link
Copy Markdown
Contributor

@stwish-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TylerMSFT TylerMSFT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code elements should be in back-tick (`) so that machine translation doesn't translate them. This bold style is all over in the C runtime docs but we will be changing it. Do you mind putting the code elements in back-tick (code) style?

@TylerMSFT

Copy link
Copy Markdown
Collaborator

@stwish-msft , now all you have to do is put #sign-off in a comment and the PR reviewers will review and merge.

@amyw-msft

Copy link
Copy Markdown
Member Author

#sign-off

@PRMerger6

Copy link
Copy Markdown
Contributor

@stwish-msft: I'm sorry - only the author of this article, @TylerMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@amyw-msft

Copy link
Copy Markdown
Member Author

@TylerMSFT Seems like only you have sign off permissions?

@TylerMSFT TylerMSFT merged commit b699dd7 into MicrosoftDocs:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants