Skip to content

Add information about ruleset schema - #2268

Merged
Kristine Toliver (ktoliver) merged 4 commits into
MicrosoftDocs:masterfrom
sunnychatterjee:patch-1
Jun 22, 2020
Merged

Kristine Toliver (ktoliver) merged 4 commits into
MicrosoftDocs:masterfrom
sunnychatterjee:patch-1

Conversation

@sunnychatterjee

Copy link
Copy Markdown
Contributor

This change adds information about the XML schema of rulesets in the existing ruleset documentation.

This change adds information about the XML schema of rulesets in the existing ruleset documentation.
@PRMerger15

Copy link
Copy Markdown
Contributor

Sunny Chatterjee (@sunnychatterjee) : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver Kristine Toliver (ktoliver) added the aq-pr-triaged Tracking label for the PR review team label Jun 17, 2020

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the intro so it is more explanatory, and we'll be good to go.

Made the into more explanatory based on Tyler's feedback.
- Added schema storage information.
- Added meaning of each schema element.
- Added pointers to sample ruleset files generated from this schema.
@PRMerger17

Copy link
Copy Markdown
Contributor

Sunny Chatterjee (@sunnychatterjee) : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sunny.
I think the list of schema elements would look better in a table, but I can do that for you.
Let's check this in and I'll update it to be a table later so you can get on to other things.

@TylerMSFT

Copy link
Copy Markdown
Collaborator

#sign-off

@PRMerger14

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT): I'm sorry - only the author of this article, @corob-msft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@colin-home

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT) This bounce seems bogus. I wonder what setting controls this?
#sign-off

@ktoliver

Copy link
Copy Markdown
Contributor

Hi Tyler Whitney (@TylerMSFT) - PRMerger looks for the value of the author metadata attribute as the "authorized" person to approve/sign off on an article that's updated in the public repository. In this repo, that value is set in docs/docfx.json. You can see that @corob-msft is set as the author of articles in this folder:

image

The PR review team can accept another authorized reviewer's approval, aka from "trusted source". You are one, so, we'll merge the PR. We sweep for approved PRs to merge twice a day M-F.

@ktoliver
Kristine Toliver (ktoliver) merged commit bfc8940 into MicrosoftDocs:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants