Repository navigation
Fix misnamed function name: fesetenv -> fesetround - #2246
Merged
Colin Robertson (colin-home) merged 2 commits intoJun 4, 2020
Merged
Conversation
added 2 commits
June 4, 2020 13:12
In my previous PR, I listed the wrong function name. I said fesetenv, but it is fesetround that modifies the rounding mode.
Also misnamed the function in this old edit.
Contributor
|
@stwish-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Colin Robertson (colin-home)
approved these changes
Jun 4, 2020
Colin Robertson (colin-home)
left a comment
Contributor
There was a problem hiding this comment.
@stwish-msft LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my latest PR and previous change to Link Options, I said fesetenv changes the rounding mode, when it is actually fesetround.