Skip to content

buil: Add MarkdownLint GitHub Action#1998

Closed
nschonni wants to merge 1 commit intoMicrosoftDocs:masterfrom
nschonni:markdownlint-github-action
Closed

buil: Add MarkdownLint GitHub Action#1998
nschonni wants to merge 1 commit intoMicrosoftDocs:masterfrom
nschonni:markdownlint-github-action

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

@nschonni nschonni commented Mar 16, 2020

This is the same setup from the dotnet/docs repo, which a slight change to ignore the TOC.md files.

@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 16, 2020

#1996 should probably land first, since otherwise the build will be red as seen over here https://github.com/nschonni/cpp-docs/runs/512291139?check_suite_focus=true

@ktoliver
Copy link
Copy Markdown
Contributor

@corob-msft Do you know what you'd like to do with this PR? Thanks.

@colin-home
Copy link
Copy Markdown
Contributor

@nschonni , @ktoliver
The reason I'm sitting on this PR is because it's in conflict with some experimental workflows we're using internally. That's why the workflows folder is currently listed in the .gitignore file. It lets us experiment with workflows independently of what gets picked up for shipping. This PR strips that protection and might let out workflows in progress that aren't ready for prime time. However, the workflow in this PR is also quite useful and something we want to provide to contributors in some form. So, no action just yet. But definitely a thumbs up and it's on the radar.

@nschonni nschonni force-pushed the markdownlint-github-action branch from 3d87785 to 5cf5c50 Compare April 20, 2020 19:39
@nschonni
Copy link
Copy Markdown
Contributor Author

@corob-msft I've updated the .gitignore so that other workflows are ignored, but this one will be included.
Alternately, I could just force add the file and not touch the gitignore, but then any further changes will need to be manually force added as well

@colin-home
Copy link
Copy Markdown
Contributor

@ktoliver Good to know, thanks!

@ktoliver
Copy link
Copy Markdown
Contributor

@corob-msft There's a technical issue in PRMerger in which this PR continually floats to the top of the PR reviewer's to-do queue. Assigning different labels and hold-off have had no effect. Because this PR might be open for an indefinite length of time, would it be OK with you if we close it, and you can reopen it when you are ready to take action on the proposed updates? Please advise. Thanks.

@colin-home
Copy link
Copy Markdown
Contributor

Closing temporarily for reviewer assistance.

@colin-home colin-home closed this Jun 24, 2020
@ktoliver
Copy link
Copy Markdown
Contributor

Thank you @corob-msft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants