Skip to content

Disable failing rules for CI enablement#1996

Merged
colin-home merged 2 commits intoMicrosoftDocs:masterfrom
nschonni:markdown-lint-disable
Jun 24, 2020
Merged

Disable failing rules for CI enablement#1996
colin-home merged 2 commits intoMicrosoftDocs:masterfrom
nschonni:markdown-lint-disable

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

@nschonni nschonni commented Mar 16, 2020 •
edited
Loading

This turns off all rules that don' currently pass running markdownlint "**/*.md" -i "**/TOC.md".
Most rules will be re-enabled, but disabling them and then enforcing the current set through GitHub Actions prevents new issues being introduced.
Some of the rules now are autofixable, so separate PRs are being submitted by removing the rule from the file and running markdownlint-cli using the --fix parameter.

@ktoliver ktoliver added the aq-pr-triaged Tracking label for the PR review team label Mar 16, 2020
@nschonni nschonni mentioned this pull request Mar 16, 2020
Closed
@colin-home
Copy link
Copy Markdown
Contributor

colin-home commented Mar 17, 2020

@nschonni I'm not sure I understand the rationale for expanding the list of markdown issues to ignore.

@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 17, 2020 •
edited
Loading

Sorry, should have given a little more context. Most of these rules should be re-enabled, and may end up looking like the original config in the end. By disabling the rules that doen't currently pass, the CI in the other PR can check that no new issues are introduced, and the other PRs like #1988 can be rebased and include a change to turn the rule back on

nschonni
nschonni commented Mar 17, 2020
View reviewed changes
@nschonni nschonni force-pushed the markdown-lint-disable branch from 662ca47 to eebdf08 Compare March 18, 2020 21:26
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 18, 2020

@corob-msft I've removed MD012 not that the other PR has landed :)

@nschonni nschonni force-pushed the markdown-lint-disable branch from eebdf08 to 48e3463 Compare March 19, 2020 13:34
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 19, 2020

Rebased for 009 and 018. Found a couple new 009s, but i'm sending it in separately

@nschonni nschonni force-pushed the markdown-lint-disable branch from 48e3463 to 2155a26 Compare March 19, 2020 21:51
@nschonni nschonni changed the title chore: Update Markdownlint with passing config Disable failing rules for CI enablement Mar 19, 2020
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 19, 2020

MD038 has been re-enabled

@nschonni nschonni force-pushed the markdown-lint-disable branch 2 times, most recently from ce52162 to 945c7b6 Compare March 20, 2020 04:28
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 20, 2020

Re-enabled MD039

@nschonni nschonni force-pushed the markdown-lint-disable branch from 945c7b6 to 1f79b91 Compare March 23, 2020 19:41
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 23, 2020

Re-enabled MD005 and MD047

@nschonni nschonni mentioned this pull request Mar 27, 2020
Merged
@nschonni nschonni force-pushed the markdown-lint-disable branch from 1f79b91 to 5bc2856 Compare March 27, 2020 17:59
@nschonni nschonni force-pushed the markdown-lint-disable branch from 5bc2856 to f961155 Compare March 27, 2020 23:10
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 27, 2020

Re-enabled MD019

@nschonni nschonni force-pushed the markdown-lint-disable branch from f961155 to d0791fa Compare March 27, 2020 23:24
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Mar 27, 2020

Re-enabled MD027

@nschonni nschonni force-pushed the markdown-lint-disable branch from d0791fa to 4817825 Compare March 30, 2020 18:52
@nschonni nschonni force-pushed the markdown-lint-disable branch from 4348098 to 921acfd Compare April 1, 2020 00:09
@ktoliver
Copy link
Copy Markdown
Contributor

ktoliver commented Apr 20, 2020

@corob-msft Do you know what you'd like to do with this PR? Thanks.

@nschonni nschonni force-pushed the markdown-lint-disable branch from 921acfd to 9375dfb Compare April 20, 2020 20:34
@nschonni nschonni force-pushed the markdown-lint-disable branch from 9375dfb to 45be0c1 Compare April 29, 2020 05:08
@nschonni
chore: Update Markdownlint with passing config
249125e 
This isn't a styleguide, but a just what the docset currently passes
@nschonni nschonni force-pushed the markdown-lint-disable branch from 45be0c1 to 249125e Compare May 13, 2020 04:52
@jborsecnik
Copy link
Copy Markdown
Contributor

jborsecnik commented Jun 1, 2020 •
edited
Loading

@corob-msft, can you review this PR? Thanks.

@ktoliver
Copy link
Copy Markdown
Contributor

ktoliver commented Jun 24, 2020

@corob-msft There's a technical issue in PRMerger in which this PR continually floats to the top of the PR reviewer's to-do queue. Assigning different labels and hold-off have had no effect. Because this PR might be open for an indefinite length of time, would it be OK with you if we close it, and you can reopen it when you are ready to take action on the proposed updates? Please advise. Thanks.

@colin-home colin-home merged commit cc66314 into MicrosoftDocs:master Jun 24, 2020
@ktoliver
Copy link
Copy Markdown
Contributor

ktoliver commented Jun 24, 2020

Thanks @corob-msft

@nschonni nschonni deleted the markdown-lint-disable branch June 25, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colin-home colin-home colin-home approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@colin-home colin-home

Labels

aq-pr-triaged Tracking label for the PR review team cpp/svc do-not-merge review-team-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@nschonni @colin-home @ktoliver @jborsecnik @PRMerger10 @PRMerger12 @PRMerger13 @PRMerger19 @Jak-MS