Add a missing underscore#1867
Merged
Merged
Conversation
I presume that this is just a typo and there isn't another similarly-named type that this refers to :)
Contributor
|
@martinthomson : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
colin-home
approved these changes
Jan 22, 2020
colin-home
left a comment
colin-home
left a comment
Contributor
There was a problem hiding this comment.
@martinthomson It's possible that name is a synonym for the two-underscore version in some relaxed compatibility mode, but yeah, looks like a typo to me. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I presume that this is just a typo and there isn't another similarly-named type that this refers to :)
(BTW, I don't know what GitHub did to the last line.)