Corrected the func definition for vector emplace#1808
Merged
colin-home merged 2 commits intoJan 4, 2020
Conversation
The emplace member function of std::vector should take const_iterator and variadic list of arguments as their input for perfect forwarding (https://en.cppreference.com/w/cpp/container/vector/emplace). This document had rvalue reference instead of variadic list of arguments. I also checked the std::vector implementation MSVC, it is now according to the changes proposed. Probably why it still had rvalue reference is explained in this link (https://stackoverflow.com/questions/4303513/push-back-vs-emplace-back).
colin-home
approved these changes
Jan 4, 2020
colin-home
left a comment
colin-home
left a comment
Contributor
There was a problem hiding this comment.
@Panky-codes Thanks for the update. This has been wrong for a long time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emplace member function of std::vector should take const_iterator and variadic list of arguments as their input for perfect forwarding link. This document had rvalue reference instead of variadic list of arguments. I also checked the std::vector implementation MSVC, it is now according to the changes proposed.
Probably why it still had rvalue reference is explained in this link link.