Repository navigation
Fix wrong path to the MathLibrary.lib file - #1733
Merged
Colin Robertson (colin-home) merged 2 commits intoFeb 10, 2020
Merged
Conversation
If the DLL and client projects are in the same solution, `..\` goes to the solution folder, while `..\MathLibrary` goes to the project folder. `MathLibrary.lib` file should be in the solution folder instead of project folder. I have tested it with real code.
Contributor
|
Hongkuan Wang (@hongkuancn) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Hi @corob-msft - Could you review the proposed change? Thanks. |
Contributor
|
@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Colin Robertson (colin-home)
approved these changes
Feb 10, 2020
Colin Robertson (colin-home)
left a comment
Contributor
There was a problem hiding this comment.
Hongkuan Wang (@hongkuancn)
Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the DLL and client projects are in the same solution,
..\goes to the solution folder, while..\MathLibrarygoes to the project folder.MathLibrary.libfile should be in the solution folder instead of project folder. I have tested it with real code.