Skip to content

Short description is wrong/misleading - #1652

Merged
Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:masterfrom
angusgraham:patch-1
Oct 25, 2019
Merged

Colin Robertson (colin-home) merged 2 commits into
MicrosoftDocs:masterfrom
angusgraham:patch-1

Conversation

@angusgraham

Copy link
Copy Markdown
Contributor

As discussed in https://github.com/MicrosoftDocs/cpp-docs/issues/1650
"Tests whether the type has a move constructor."
That is not true.
As stated on https://en.cppreference.com/w/cpp/types/is_move_constructible:
Types without a move constructor, but with a copy constructor that accepts const T& arguments, satisfy std::is_move_constructible.

As discussed in https://github.com/MicrosoftDocs/cpp-docs/issues/1650
"Tests whether the type has a move constructor."
That is not true.
As stated on https://en.cppreference.com/w/cpp/types/is_move_constructible:
Types without a move constructor, but with a copy constructor that accepts const T& arguments, satisfy std::is_move_constructible.
@PRMerger6

Copy link
Copy Markdown
Contributor

angusgraham : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger9

Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angusgraham Thanks for contributing!

@colin-home
Colin Robertson (colin-home) merged commit c6e3ec4 into MicrosoftDocs:master Oct 25, 2019
@angusgraham
angusgraham deleted the patch-1 branch October 25, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author do-not-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants