Skip to content

Change "import existing cache" to "open existing cache"#1600

Merged
colin-home merged 3 commits intoMicrosoftDocs:masterfrom
esweet431:patch-10
Oct 2, 2019
Merged

Change "import existing cache" to "open existing cache"#1600
colin-home merged 3 commits intoMicrosoftDocs:masterfrom
esweet431:patch-10

Conversation

@esweet431
Copy link
Copy Markdown
Contributor

@esweet431 esweet431 commented Oct 2, 2019

In Visual Studio 2019 we have support for "opening an existing cache", which operates with the existing cache in place rather than duplicating it. I've updated this section and linked to Will's blog post for more information.

@esweet431
Change "import existing cache" to "open existing cache"
d33fcd6 
In Visual Studio 2019 we have support for "opening an existing cache", which operates with the existing cache in place rather than duplicating it. I've updated this section and linked to Will's blog post for more information.
@PRMerger6
Copy link
Copy Markdown
Contributor

PRMerger6 commented Oct 2, 2019

@esweet431 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger6 PRMerger6 requested a review from colin-home October 2, 2019 00:01
@esweet431
Copy link
Copy Markdown
Contributor Author

esweet431 commented Oct 2, 2019

It seems like this PR dup'd my other PR, which had a few minor changes to the "Installation" and "IDE integration" sections

@colin-home
Copy link
Copy Markdown
Contributor

colin-home commented Oct 2, 2019

@esweet431
It probably looks like a you're reverting changes because the public repo master branch now has your previous changes applied, but your new changes may have been based on the state of master from before those changes. You could merge master into your patch-10 branch, or maybe just copy your latest changes and apply them again on the current public version of the article. It's possible that the merge can figure it out and do the right thing, too.

@colin-home
Copy link
Copy Markdown
Contributor

colin-home commented Oct 2, 2019

@esweet431
Do you mean to close this PR in favor of #1601 instead?

@jborsecnik jborsecnik added the aq-pr-triaged Tracking label for the PR review team label Oct 2, 2019
@esweet431
Copy link
Copy Markdown
Contributor Author

esweet431 commented Oct 2, 2019

@corob-msft I think I few changes are in this PR only. I can either close this PR and make the final edits once the changes are live, or we can merge this PR and hope the merge will do the right thing.

@jborsecnik
Copy link
Copy Markdown
Contributor

jborsecnik commented Oct 2, 2019

Note that there's a merge conflict here that would have to be resolved before we could merge.

@PRMerger19
Copy link
Copy Markdown
Contributor

PRMerger19 commented Oct 2, 2019

@esweet431 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@esweet431
Copy link
Copy Markdown
Contributor Author

esweet431 commented Oct 2, 2019

Just resolved, thanks.

@colin-home
Copy link
Copy Markdown
Contributor

colin-home commented Oct 2, 2019

@esweet431
Erika, before I approve this, take a look at the file view diff. It looks like the first four diff sections undo changes you made in #1598 and #1599. I want to make sure that is your intent before approving and merging this PR.

@esweet431
Fixed first 3 sections
8216bc4 
This change updates the first 3 sections - CMake Projects in Visual Studio, Installation, and IDE Integration to include my changes from 1598 and 1599. This patch should now include all of my proposed changes.
@PRMerger6
Copy link
Copy Markdown
Contributor

PRMerger6 commented Oct 2, 2019

@esweet431 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@colin-home colin-home merged commit a20eed2 into MicrosoftDocs:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colin-home colin-home colin-home approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@colin-home colin-home

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author do-not-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@esweet431 @PRMerger6 @colin-home @jborsecnik @PRMerger19