Skip to content

describe the variadic template args now used, fill in missing parts - #145

Merged
Colin Robertson (colin-home) merged 4 commits into
MicrosoftDocs:masterfrom
ChrisGuzak:patch-1
Dec 11, 2017
Merged

describe the variadic template args now used, fill in missing parts#145
Colin Robertson (colin-home) merged 4 commits into
MicrosoftDocs:masterfrom
ChrisGuzak:patch-1

Conversation

@ChrisGuzak

Copy link
Copy Markdown
Contributor

This page was documenting the pre-Variadic template arg version of this function, was missing several important things so I've updated it. Raymond Chen (@oldnewthing) please check my work.

This page was documenting the pre-Variadic template arg version of this function, was missing several important things so I've updated it
Comment thread docs/windows/runtimeclass-class.md Outdated
`RuntimeClass`

`RuntimeClass`
This is an implementaiton detail.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Comment thread docs/windows/runtimeclass-class.md Outdated
A combination of one or more [RuntimeClassType](../windows/runtimeclasstype-enumeration.md) enumeration values. The `__WRL_CONFIGURATION_LEGACY__` macro can be defined to change the default value of classFlags for all runtime classes in the project. If defined, RuntimeClass instances are non-agile dy default. When not defined, RuntimeClass instances are agile by default. To avoid ambiguity always specify the RuntimeClassType::FtmBase or RuntimeClassType::InhibitFtmBase.
Optional paramater. A combination of one or more [RuntimeClassType](../windows/runtimeclasstype-enumeration.md) enumeration values. The `__WRL_CONFIGURATION_LEGACY__` macro can be defined to change the default value of classFlags for all runtime classes in the project. If defined, RuntimeClass instances are non-agile dy default. When not defined, RuntimeClass instances are agile by default. To avoid ambiguity always specify the RuntimeClassType::FtmBase or RuntimeClassType::InhibitFtmBase. Note, if InhibitFtmBase and FtmBase are both used the object will be agile.

`...TInterfaces`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also put an Implements here (rather than an interface). Maybe somebody who knows more can fill in the details.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave that for later.

Comment thread docs/windows/runtimeclass-class.md Outdated
Optional paramater. A combination of one or more [RuntimeClassType](../windows/runtimeclasstype-enumeration.md) enumeration values. The `__WRL_CONFIGURATION_LEGACY__` macro can be defined to change the default value of classFlags for all runtime classes in the project. If defined, RuntimeClass instances are non-agile dy default. When not defined, RuntimeClass instances are agile by default. To avoid ambiguity always specify the RuntimeClassType::FtmBase or RuntimeClassType::InhibitFtmBase. Note, if InhibitFtmBase and FtmBase are both used the object will be agile.

`...TInterfaces`
The list of interfaces the object implements beyond IUnknown, IInspectable or other interfaces controled by [RuntimeClassType](../windows/runtimeclasstype-enumeration.md).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYPO: controlled.

Comment thread docs/windows/runtimeclass-class.md Outdated
## Members

`RuntimeClassInitialize`
A function that is called when MakeAndInitialize() is used to construct the object that contains initialization code that can return an HRESULT to indicate failure (S_OK otherwise).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing grammar. (Antecedent of "that" is ambiguous.) Suggest

A function which initializes the object if the MakeAndInitialize template function is used to construct the object. It returns S_OK if the object was successfully initialized, or a COM error code if initialization failed. The COM error code is propagated as the return value of MakeAndInitialize. Note that the RuntimeClassInitialize method is not called if the Make template function is used to construct the object.

@mikeblome Mike B (mikeblome) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys!

@colin-home
Colin Robertson (colin-home) merged commit edcb54a into MicrosoftDocs:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants