RAII 4 translator + const/noexcept correct SE_Exception#1302
Merged
colin-home merged 2 commits intoMicrosoftDocs:masterfrom Jul 16, 2019
dimhotepus:patch-1
Merged
RAII 4 translator + const/noexcept correct SE_Exception#1302colin-home merged 2 commits intoMicrosoftDocs:masterfrom dimhotepus:patch-1
colin-home merged 2 commits intoMicrosoftDocs:masterfrom
dimhotepus:patch-1
Conversation
* Use RAII idiom for structured exception translator setter. * Make `SE_Exception` const and noexcept correct. * Remove unused `<assert.h>` header. Didn't converted `printf` to `std::cerr`. IMHO stream formatters a bit harder to reason about than printf ones.
|
|
Contributor
|
@dimhotepus : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
colin-home
approved these changes
Jul 16, 2019
Contributor
colin-home
left a comment
colin-home
left a comment
There was a problem hiding this comment.
@dimhotepus Very stylish code, thanks for contributing. Sorry it's taken so long to get to this review.
Contributor
Author
|
@corob-msft Never mind thank you for review and fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SE_Exceptionconst and noexcept correct.<assert.h>header.Didn't converted
printftostd::cerr.IMHO stream formatters a bit harder to reason about than printf ones.