Add refresh button to description page - #771
Merged
Merged
Conversation
Peng Lyu (rebornix)
approved these changes
Jan 4, 2019
Peng Lyu (rebornix)
left a comment
Peng Lyu (rebornix)
left a comment
Contributor
There was a problem hiding this comment.
The code looks good to me. I found that the set-scroll in update doesn't work as expected somehow but it's unrelated to this pr.
this._postMessage({
command: 'set-scroll',
scrollPosition: this._scrollPosition,
});
Contributor
Author
|
what's the behavior you're seeing for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103