Skip to content

Code lens debug java 9 test case: "ConfigError: 'com.microsoft.app.mymodule/com.microsoft.app.App' is not a valid class name." #437

New issue
New issue
Closed
Closed
Code lens debug java 9 test case: "ConfigError: 'com.microsoft.app.mymodule/com.microsoft.app.App' is not a valid class name."#437
Assignees
testforstephen
Labels
bug
Milestone
0.14.0

Description

@sallyur
Sally Liu (sallyur)
opened on Sep 19, 2018
Environment
  • Operating System: Windows
  • JDK version: 10
  • Visual Studio Code version: 1.27.2
  • Java extension version: 0.31.0
  • Java Debugger extension version: 0.13.0
  • Build: 61
Steps To Reproduce
  1. Open the project 19. java9 - app
  2. Open App.java
  3. Use code lens to debug or run the project
Result: report error

image

Activity

  1. Jinbo Wang (testforstephen)
    added
    bug
    on Sep 19, 2018
  2. Jinbo Wang (testforstephen)
    self-assigned this
    on Sep 19, 2018

  3. testforstephen commented on Sep 19, 2018

    @testforstephen
    Jinbo Wang (testforstephen)
    on Sep 19, 2018
    Contributor

    Currently we use the regular expression ([$\\w]+\\.)*[$\\w]+ to validate the class name, it doesn't cover Java 9 case. This is a bug.

  4. Andy Xu(devdiv) (andxu)
    added this to the 0.14.0 milestone on Sep 20, 2018
  5. Jinbo Wang (testforstephen)
    closed this as completedon Oct 9, 2018

  6. testforstephen commented on Oct 9, 2018

    @testforstephen
    Jinbo Wang (testforstephen)
    on Oct 9, 2018
    Contributor

    Java command line supports two kinds of main class format: <mainclass> and <module>[/<mainclass>]

    The regular expression should support these two cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions