Merged
Conversation
mhegazy
approved these changes
Jun 6, 2017
|
will miss this shirt #13039 (comment) |
| const instantiatedType = instantiateType(contextualType, cloneTypeMapper(getContextualMapper(node))); | ||
| // If the contextual type is a generic pure function type, we instantiate the type with | ||
| // its own type parameters and type arguments. This ensures that the type parameters are | ||
| // not erased to type any during type inference such that they can be inferred as actual |
| // Inferences made from return types have lower priority than all other inferences. | ||
| inferTypes(context.inferences, instantiatedType, returnType, InferencePriority.ReturnType); | ||
| const instantiatedType = instantiateType(contextualType, cloneTypeMapper(getContextualMapper(node))); | ||
| // If the contextual type is a generic pure function type, we instantiate the type with |
Member
There was a problem hiding this comment.
What is meant by "generic pure function type"?
Member
Author
There was a problem hiding this comment.
A type that has nothing but a single call signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we do not erase the type parameters of contextual generic function types. Instead, the type parameters are allowed to propagate into the contextually typed expression. For example:
Previously, contextual generic function types were ignored and
awould therefore have been of typeany.This PR also expands upon #16072 to permit the contextual type of a generic function to itself be a generic function type. For example:
Fixes #16293.