Skip to content

Update code style - #129

Merged
PerthCharern merged 8 commits into
masterfrom
PerthCharern/Guideline
Dec 13, 2017
Merged

PerthCharern merged 8 commits into
masterfrom
PerthCharern/Guideline

Conversation

@PerthCharern

Copy link
Copy Markdown
Contributor

Fixes #16

  • Update code to adhere to the coding guidelines

Fixes #114

  • Add DefaultCollections to all test classes

Also, modify the workbench to reset the output when error occurs.

Add license header
- fix the output/error issue in Workbench
fix issue in Constants
Add comments to StringExtensions
{
get
{
if (string.IsNullOrEmpty(Value))

@scott-lin Scott Lin (scott-lin) Dec 13, 2017 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsNullOrEmpty [](start = 27, length = 13)

double-checking, white space allowed? #Resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is since Value is supposed to be a JSON pointer. I'll change


In reply to: 156533248 [](ancestors = 156533248)

@scott-lin Scott Lin (scott-lin) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PerthCharern

Copy link
Copy Markdown
Contributor Author

Given the number of files this PR is touching, I'll merge it as soon as I can to avoid creating future conflicts.

@PerthCharern
PerthCharern merged commit 4ae5fb5 into master Dec 13, 2017
@PerthCharern
PerthCharern deleted the PerthCharern/Guideline branch December 13, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants