Repository navigation
Update code style - #129
Merged
Merged
Conversation
Add license header
- fix the output/error issue in Workbench
fix issue in Constants Add comments to StringExtensions
PerthCharern
requested review from
Darrel (darrelmiller),
Scott Lin (scott-lin) and
Sam Xu (xuzhg)
December 13, 2017 00:08
| { | ||
| get | ||
| { | ||
| if (string.IsNullOrEmpty(Value)) |
Contributor
There was a problem hiding this comment.
IsNullOrEmpty [](start = 27, length = 13)
double-checking, white space allowed? #Resolved
Contributor
Author
There was a problem hiding this comment.
I don't think it is since Value is supposed to be a JSON pointer. I'll change
In reply to: 156533248 [](ancestors = 156533248)
Fix csproj files
Contributor
Author
|
Given the number of files this PR is touching, I'll merge it as soon as I can to avoid creating future conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
Fixes #114
Also, modify the workbench to reset the output when error occurs.