AppStore app: don't create unnecessary additional thread

ThomasFarstrike · ThomasFarstrike · commit 87f3bfeba181 · 2025-11-01T09:51:18.000+01:00
diff --git a/internal_filesystem/builtin/apps/com.micropythonos.appstore/assets/appstore.py b/internal_filesystem/builtin/apps/com.micropythonos.appstore/assets/appstore.py
@@ -70,6 +70,7 @@ def download_app_index(self, json_url):
                 time.sleep_ms(200)
                 self.update_ui_threadsafe_if_foreground(self.please_wait_label.add_flag, lv.obj.FLAG.HIDDEN)
                 self.update_ui_threadsafe_if_foreground(self.create_apps_list)
+                self.download_icons()
             except Exception as e:
                 print(f"ERROR: could not parse reponse.text JSON: {e}")
             finally:
@@ -119,11 +120,6 @@ def create_apps_list(self):
             desc_label.set_style_text_font(lv.font_montserrat_12, 0)
             desc_label.add_event_cb(lambda e, a=app: self.show_app_detail(a), lv.EVENT.CLICKED, None)
         print("create_apps_list app done")
-        try:
-            _thread.stack_size(mpos.apps.good_stack_size())
-            _thread.start_new_thread(self.download_icons,()) # maybe there's no need for a new thread here, just do it in download_app_index()?
-        except Exception as e:
-            print("Could not start thread to download icons: ", e)
     
     def download_icons(self):
         for app in self.apps:
