Skip to content

Commit 84be8f6

Browse files
Fix failing test
1 parent b62e115 commit 84be8f6

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

tests/test_osupdate.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
# Import network test helpers
1010
from network_test_helper import MockNetwork, MockRequests, MockJSON, MockDownloadManager
1111

12+
# Import the real DownloadManager for is_network_error function
13+
from mpos import DownloadManager
14+
1215

1316
class MockPartition:
1417
"""Mock ESP32 Partition for testing UpdateDownloader."""
@@ -389,34 +392,34 @@ async def run_test():
389392
def test_network_error_detection_econnaborted(self):
390393
"""Test that ECONNABORTED error is detected as network error."""
391394
error = OSError(-113, "ECONNABORTED")
392-
self.assertTrue(self.downloader._is_network_error(error))
395+
self.assertTrue(DownloadManager.is_network_error(error))
393396

394397
def test_network_error_detection_econnreset(self):
395398
"""Test that ECONNRESET error is detected as network error."""
396399
error = OSError(-104, "ECONNRESET")
397-
self.assertTrue(self.downloader._is_network_error(error))
400+
self.assertTrue(DownloadManager.is_network_error(error))
398401

399402
def test_network_error_detection_etimedout(self):
400403
"""Test that ETIMEDOUT error is detected as network error."""
401404
error = OSError(-110, "ETIMEDOUT")
402-
self.assertTrue(self.downloader._is_network_error(error))
405+
self.assertTrue(DownloadManager.is_network_error(error))
403406

404407
def test_network_error_detection_ehostunreach(self):
405408
"""Test that EHOSTUNREACH error is detected as network error."""
406409
error = OSError(-118, "EHOSTUNREACH")
407-
self.assertTrue(self.downloader._is_network_error(error))
410+
self.assertTrue(DownloadManager.is_network_error(error))
408411

409412
def test_network_error_detection_by_message(self):
410413
"""Test that network errors are detected by message."""
411-
self.assertTrue(self.downloader._is_network_error(Exception("Connection reset by peer")))
412-
self.assertTrue(self.downloader._is_network_error(Exception("Connection aborted")))
413-
self.assertTrue(self.downloader._is_network_error(Exception("Broken pipe")))
414+
self.assertTrue(DownloadManager.is_network_error(Exception("Connection reset by peer")))
415+
self.assertTrue(DownloadManager.is_network_error(Exception("Connection aborted")))
416+
self.assertTrue(DownloadManager.is_network_error(Exception("Broken pipe")))
414417

415418
def test_non_network_error_not_detected(self):
416419
"""Test that non-network errors are not detected as network errors."""
417-
self.assertFalse(self.downloader._is_network_error(ValueError("Invalid data")))
418-
self.assertFalse(self.downloader._is_network_error(Exception("File not found")))
419-
self.assertFalse(self.downloader._is_network_error(KeyError("missing")))
420+
self.assertFalse(DownloadManager.is_network_error(ValueError("Invalid data")))
421+
self.assertFalse(DownloadManager.is_network_error(Exception("File not found")))
422+
self.assertFalse(DownloadManager.is_network_error(KeyError("missing")))
420423

421424
def test_download_pauses_on_network_error_during_read(self):
422425
"""Test that download pauses when network error occurs during read."""

0 commit comments

Comments
 (0)