Skip to content

Commit 189d4a8

Browse files
ThomasFarstrikeThomasFarstrike
committed
More tests
1 parent b714ad8 commit 189d4a8

File tree

3 files changed

+349
-0
lines changed

3 files changed

+349
-0
lines changed

‎tests/manual_test_keyboard_typing.py‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
"""
2+
Manual test for MposKeyboard typing behavior.
3+
4+
This test allows you to manually type on the keyboard and verify:
5+
1. Only one character is added per button press (not doubled)
6+
2. Mode switching works correctly
7+
3. Special characters work
8+
9+
Run with: ./scripts/run_desktop.sh tests/manual_test_keyboard_typing.py
10+
"""
11+
12+
import lvgl as lv
13+
from mpos.ui.keyboard import MposKeyboard
14+
15+
# Get active screen
16+
screen = lv.screen_active()
17+
screen.clean()
18+
19+
# Create a textarea to type into
20+
textarea = lv.textarea(screen)
21+
textarea.set_size(280, 60)
22+
textarea.align(lv.ALIGN.TOP_MID, 0, 20)
23+
textarea.set_placeholder_text("Type here to test keyboard...")
24+
25+
# Create instructions label
26+
label = lv.label(screen)
27+
label.set_text("Test keyboard typing:\n"
28+
"- Each key should add ONE character\n"
29+
"- Try mode switching (UP/DOWN, ?123)\n"
30+
"- Check backspace works\n"
31+
"- Press ESC to exit")
32+
label.set_size(280, 80)
33+
label.align(lv.ALIGN.TOP_MID, 0, 90)
34+
label.set_style_text_align(lv.TEXT_ALIGN.CENTER, 0)
35+
36+
# Create the keyboard
37+
keyboard = MposKeyboard(screen)
38+
keyboard.set_textarea(textarea)
39+
keyboard.align(lv.ALIGN.BOTTOM_MID, 0, 0)
40+
41+
print("\n" + "="*50)
42+
print("Manual Keyboard Test")
43+
print("="*50)
44+
print("Click on keyboard buttons and observe the textarea.")
45+
print("Each button should add exactly ONE character.")
46+
print("If you see double characters, the bug exists.")
47+
print("Press ESC or close window to exit.")
48+
print("="*50 + "\n")

‎tests/manual_test_wifi_password.py‎

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
"""
2+
Manual test for WiFi password page keyboard.
3+
4+
This test allows you to manually type and check for double characters.
5+
6+
Run with: ./scripts/run_desktop.sh tests/manual_test_wifi_password.py
7+
8+
Instructions:
9+
1. Click on the password field
10+
2. Type some characters
11+
3. Check if each keypress adds ONE character or TWO
12+
4. If you see doubles, the bug exists
13+
"""
14+
15+
import lvgl as lv
16+
from mpos.ui.keyboard import MposKeyboard
17+
18+
# Get active screen
19+
screen = lv.screen_active()
20+
screen.clean()
21+
22+
# Create title label
23+
title = lv.label(screen)
24+
title.set_text("WiFi Password Test")
25+
title.align(lv.ALIGN.TOP_MID, 0, 10)
26+
27+
# Create textarea (simulating WiFi password field)
28+
password_ta = lv.textarea(screen)
29+
password_ta.set_width(lv.pct(90))
30+
password_ta.set_one_line(True)
31+
password_ta.align_to(title, lv.ALIGN.OUT_BOTTOM_MID, 0, 10)
32+
password_ta.set_placeholder_text("Type here...")
33+
password_ta.set_text("") # Start empty
34+
35+
# Create instruction label
36+
instructions = lv.label(screen)
37+
instructions.set_text("Click above and type.\nWatch for DOUBLE characters.\nEach key should add ONE char only.")
38+
instructions.set_style_text_align(lv.TEXT_ALIGN.CENTER, 0)
39+
instructions.align(lv.ALIGN.CENTER, 0, 0)
40+
41+
# Create keyboard (like WiFi app does)
42+
keyboard = MposKeyboard(screen)
43+
keyboard.align(lv.ALIGN.BOTTOM_MID, 0, 0)
44+
keyboard.set_textarea(password_ta) # This might cause double-typing!
45+
keyboard.set_style_min_height(165, 0)
46+
47+
# Add event handler like WiFi app does (to detect READY/CANCEL)
48+
def handle_keyboard_events(event):
49+
target_obj = event.get_target_obj()
50+
button = target_obj.get_selected_button()
51+
text = target_obj.get_button_text(button)
52+
print(f"Event: button={button}, text={text}, textarea='{password_ta.get_text()}'")
53+
if text == lv.SYMBOL.NEW_LINE:
54+
print("Enter pressed")
55+
56+
keyboard.add_event_cb(handle_keyboard_events, lv.EVENT.VALUE_CHANGED, None)
57+
58+
print("\n" + "="*60)
59+
print("WiFi Password Keyboard Test")
60+
print("="*60)
61+
print("Type on the keyboard and watch the textarea.")
62+
print("BUG: If each keypress adds TWO characters instead of ONE,")
63+
print(" then we have the double-character bug!")
64+
print("")
65+
print("Expected: typing 'hello' should show 'hello'")
66+
print("Bug: typing 'hello' shows 'hheelllloo'")
67+
print("="*60)
68+
print("\nPress ESC or close window to exit.")

‎tests/test_graphical_wifi_keyboard.py‎

Lines changed: 233 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,233 @@
1+
"""
2+
Test for WiFi app keyboard double-character bug.
3+
4+
This test reproduces the issue where typing on the keyboard in the WiFi
5+
password page results in double characters being added to the textarea.
6+
7+
Usage:
8+
Desktop: ./tests/unittest.sh tests/test_graphical_wifi_keyboard.py
9+
Device: ./tests/unittest.sh tests/test_graphical_wifi_keyboard.py --ondevice
10+
"""
11+
12+
import unittest
13+
import lvgl as lv
14+
from mpos.ui.keyboard import MposKeyboard
15+
from graphical_test_helper import wait_for_render
16+
17+
18+
class TestWiFiKeyboard(unittest.TestCase):
19+
"""Test WiFi app keyboard behavior."""
20+
21+
def setUp(self):
22+
"""Set up test fixtures."""
23+
self.screen = lv.obj()
24+
self.screen.set_size(320, 240)
25+
lv.screen_load(self.screen)
26+
wait_for_render(5)
27+
28+
def tearDown(self):
29+
"""Clean up."""
30+
lv.screen_load(lv.obj())
31+
wait_for_render(5)
32+
33+
def test_keyboard_with_set_textarea(self):
34+
"""
35+
Test that keyboard with set_textarea doesn't double characters.
36+
37+
This simulates how the WiFi app uses the keyboard:
38+
1. Create keyboard
39+
2. Call set_textarea()
40+
3. Type a character
41+
4. Verify only ONE character is added, not two
42+
"""
43+
print("\n=== Testing keyboard with set_textarea ===")
44+
45+
# Create textarea (like WiFi password field)
46+
textarea = lv.textarea(self.screen)
47+
textarea.set_size(200, 30)
48+
textarea.set_one_line(True)
49+
textarea.align(lv.ALIGN.TOP_MID, 0, 10)
50+
textarea.set_text("") # Start empty
51+
wait_for_render(5)
52+
53+
# Create keyboard and connect to textarea (like WiFi app does)
54+
keyboard = MposKeyboard(self.screen)
55+
keyboard.set_textarea(textarea)
56+
keyboard.align(lv.ALIGN.BOTTOM_MID, 0, 0)
57+
wait_for_render(10)
58+
59+
print(f"Initial textarea: '{textarea.get_text()}'")
60+
self.assertEqual(textarea.get_text(), "", "Textarea should start empty")
61+
62+
# Now we need to simulate typing a character
63+
# The problem is that LVGL's keyboard has built-in auto-typing when set_textarea is called
64+
# AND our custom handler also types. This causes doubles.
65+
66+
# Let's manually trigger what happens when a button is pressed
67+
# Find the 'a' button
68+
a_button_index = None
69+
for i in range(100):
70+
try:
71+
text = keyboard.get_button_text(i)
72+
if text == "a":
73+
a_button_index = i
74+
print(f"Found 'a' button at index {i}")
75+
break
76+
except:
77+
pass
78+
79+
self.assertIsNotNone(a_button_index, "Should find 'a' button")
80+
81+
# Get initial text
82+
initial_text = textarea.get_text()
83+
print(f"Text before simulated keypress: '{initial_text}'")
84+
85+
# Simulate a button press by calling the underlying keyboard's event mechanism
86+
# This is tricky to simulate properly in a test...
87+
# Let's try a different approach: directly call our handler
88+
89+
# Create a mock event
90+
class MockEvent:
91+
def get_code(self):
92+
return lv.EVENT.VALUE_CHANGED
93+
94+
# Manually set which button is selected
95+
# (We can't actually set it, but our handler will query it)
96+
# This is hard to test without actual user interaction
97+
98+
# Alternative: Just verify the handler logic is sound
99+
print("Testing that handler exists and filters correctly")
100+
self.assertTrue(hasattr(keyboard, '_handle_events'))
101+
102+
# For now, document the expected behavior
103+
print("\nExpected behavior:")
104+
print("- User clicks 'a' button")
105+
print("- LVGL fires VALUE_CHANGED event")
106+
print("- Our handler processes it ONCE")
107+
print("- Exactly ONE 'a' should be added to textarea")
108+
print("\nIf doubles occur, the bug is:")
109+
print("- LVGL's built-in handler types the character")
110+
print("- Our custom handler ALSO types it")
111+
print("- Result: 'aa' instead of 'a'")
112+
113+
def test_keyboard_manual_text_insertion(self):
114+
"""
115+
Test simulating the double-character bug by manually inserting text twice.
116+
117+
This demonstrates what happens when both LVGL's default handler
118+
and our custom handler try to insert the same character.
119+
"""
120+
print("\n=== Simulating double-character bug ===")
121+
122+
textarea = lv.textarea(self.screen)
123+
textarea.set_size(200, 30)
124+
textarea.set_one_line(True)
125+
textarea.align(lv.ALIGN.TOP_MID, 0, 10)
126+
textarea.set_text("")
127+
wait_for_render(5)
128+
129+
keyboard = MposKeyboard(self.screen)
130+
keyboard.set_textarea(textarea)
131+
keyboard.align(lv.ALIGN.BOTTOM_MID, 0, 0)
132+
wait_for_render(10)
133+
134+
# Simulate what happens if BOTH handlers fire:
135+
# 1. LVGL's default handler inserts "a"
136+
# 2. Our custom handler also inserts "a"
137+
# Result: "aa"
138+
139+
initial = textarea.get_text()
140+
print(f"Initial: '{initial}'")
141+
142+
# Simulate first insertion (LVGL default)
143+
textarea.set_text(initial + "a")
144+
wait_for_render(2)
145+
after_first = textarea.get_text()
146+
print(f"After first insertion: '{after_first}'")
147+
148+
# Simulate second insertion (our handler)
149+
textarea.set_text(after_first + "a")
150+
wait_for_render(2)
151+
after_second = textarea.get_text()
152+
print(f"After second insertion (DOUBLE BUG): '{after_second}'")
153+
154+
self.assertEqual(after_second, "aa", "Bug creates double characters")
155+
print("\nThis is the BUG: typing 'a' once results in 'aa'")
156+
157+
def test_keyboard_without_set_textarea(self):
158+
"""
159+
Test keyboard WITHOUT calling set_textarea.
160+
161+
This tests if we can avoid the double-character bug by NOT
162+
connecting the keyboard to the textarea with set_textarea(),
163+
and instead relying only on our custom handler.
164+
"""
165+
print("\n=== Testing keyboard WITHOUT set_textarea ===")
166+
167+
textarea = lv.textarea(self.screen)
168+
textarea.set_size(200, 30)
169+
textarea.set_one_line(True)
170+
textarea.align(lv.ALIGN.TOP_MID, 0, 10)
171+
textarea.set_text("")
172+
wait_for_render(5)
173+
174+
keyboard = MposKeyboard(self.screen)
175+
# DON'T call set_textarea() - handle it manually
176+
# keyboard.set_textarea(textarea) # <-- Commented out
177+
keyboard.align(lv.ALIGN.BOTTOM_MID, 0, 0)
178+
wait_for_render(10)
179+
180+
print("Keyboard created WITHOUT set_textarea()")
181+
print("In this mode, LVGL won't auto-insert characters")
182+
print("Only our custom handler should insert characters")
183+
print("This should prevent double characters")
184+
185+
# Verify keyboard exists
186+
self.assertIsNotNone(keyboard)
187+
print("SUCCESS: Can create keyboard without set_textarea")
188+
189+
def test_set_textarea_stores_reference(self):
190+
"""
191+
Test that set_textarea stores the textarea reference internally.
192+
193+
This is the FIX for the double-character bug. MposKeyboard stores
194+
the textarea reference itself and does NOT pass it to the underlying
195+
LVGL keyboard widget. This prevents LVGL's auto-insertion which
196+
would cause double characters.
197+
"""
198+
print("\n=== Testing set_textarea stores reference correctly ===")
199+
200+
textarea = lv.textarea(self.screen)
201+
textarea.set_size(200, 30)
202+
textarea.set_one_line(True)
203+
textarea.align(lv.ALIGN.TOP_MID, 0, 10)
204+
wait_for_render(5)
205+
206+
keyboard = MposKeyboard(self.screen)
207+
keyboard.align(lv.ALIGN.BOTTOM_MID, 0, 0)
208+
wait_for_render(5)
209+
210+
# Initially no textarea
211+
self.assertIsNone(keyboard.get_textarea(),
212+
"Keyboard should have no textarea initially")
213+
214+
# Set the textarea
215+
keyboard.set_textarea(textarea)
216+
wait_for_render(2)
217+
218+
# Verify it's stored in our reference
219+
self.assertEqual(keyboard.get_textarea(), textarea,
220+
"get_textarea() should return our textarea")
221+
222+
# Verify the internal storage
223+
self.assertTrue(hasattr(keyboard, '_textarea'),
224+
"Keyboard should have _textarea attribute")
225+
self.assertEqual(keyboard._textarea, textarea,
226+
"Internal _textarea should be our textarea")
227+
228+
print("SUCCESS: set_textarea stores reference correctly")
229+
print("This prevents LVGL auto-insertion and fixes double-character bug!")
230+
231+
232+
if __name__ == "__main__":
233+
unittest.main()

0 commit comments

Comments
 (0)