Skip to content

forex_python.converter.RatesNotAvailableError: Currency Rates Source … #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhijit111093 merged 1 commit into from
Sep 2, 2021
Merged

forex_python.converter.RatesNotAvailableError: Currency Rates Source … #102

abhijit111093 merged 1 commit into from
Sep 2, 2021

Conversation

@abhijit111093
Copy link
Contributor

@abhijit111093 abhijit111093 commented Sep 2, 2021

…Not Ready issue fixed

@abhijit111093 abhijit111093 merged commit 0ca3add into master Sep 2, 2021
@Robbie-Palmer
Copy link
Contributor

Robbie-Palmer commented Nov 6, 2021

@abhijit111093 this change causes the tests on the master branch to fail

Leaving commented out code in a repository is also bad practice
Because it is unnecessary when using git (the old code can always be retrieved from the git history if required, so deleting is not a problem)
And it will confuse / mislead developers who when they read it will wonder why it's there, if it's planned to be returned etc.

Robbie-Palmer added a commit to Robbie-Palmer/forex-python that referenced this pull request Nov 6, 2021
@Robbie-Palmer
Revert "Merge pull request MicroPyramid#102 from MicroPyramid/Currenc…
4a08ff5 
…y_Rates_Source_Not_Ready"

This reverts commit 0ca3add, reversing
changes made to fcc62b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abhijit111093 @Robbie-Palmer