Skip to content

Add incremental build support to MessagePack.MSBuild.Tasks#1528

Merged
AArnott merged 1 commit intoMessagePack-CSharp:masterfrom
AArnott:fix1526
Nov 19, 2022
Merged

Add incremental build support to MessagePack.MSBuild.Tasks#1528
AArnott merged 1 commit intoMessagePack-CSharp:masterfrom
AArnott:fix1526

Conversation

@AArnott
Copy link
Collaborator

@AArnott AArnott commented Nov 19, 2022

Fixes #1526

@AArnott AArnott added this to the v2.4 milestone Nov 19, 2022
@AArnott AArnott merged commit e9cdd76 into MessagePack-CSharp:master Nov 19, 2022
@AArnott AArnott deleted the fix1526 branch November 19, 2022 15:52
@hankovich
Copy link
Contributor

It looks like the GeneratedFileName constant in the task is no longer needed.

@AArnott
Copy link
Collaborator Author

AArnott commented Nov 19, 2022

Ah yes, good eye @hankovich. I'll make a follow-up PR to clean that up.

@AArnott
Copy link
Collaborator Author

AArnott commented Nov 19, 2022

see #1529

@hankovich
Copy link
Contributor

see #1529

Great stuff!
Thanks for the quick fix. When are you going release a new package version?

@AArnott
Copy link
Collaborator Author

AArnott commented Nov 19, 2022

See #1519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GenerateMessagePackResolver MsBuild target breaks incremental build

2 participants