Skip to content

Add support for C# 9 record types in mpc#1288

Merged
AArnott merged 1 commit intoMessagePack-CSharp:developfrom
AArnott:fix1274
Jul 17, 2021
Merged

Add support for C# 9 record types in mpc#1288
AArnott merged 1 commit intoMessagePack-CSharp:developfrom
AArnott:fix1274

Conversation

@AArnott
Copy link
Collaborator

@AArnott AArnott commented Jul 15, 2021

Update mpc roslyn dependency to 3.10.0

This fixes #1274 by updating to a compiler version that supports C# 9 record type declarations.

This fixes MessagePack-CSharp#1274 by updating to a compiler version that supports C# 9 `record` type declarations.
@AArnott AArnott requested a review from neuecc July 15, 2021 21:57
@AArnott AArnott self-assigned this Jul 15, 2021
@AArnott AArnott added this to the v2.3 milestone Jul 15, 2021
@AArnott AArnott linked an issue Jul 15, 2021 that may be closed by this pull request
@AArnott AArnott changed the title Update mpc roslyn dependency to 3.10.0 Add support for C# 9 record types in mpc Jul 15, 2021
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see.
Thanks.

@AArnott AArnott merged commit 3704099 into MessagePack-CSharp:develop Jul 17, 2021
@AArnott AArnott deleted the fix1274 branch July 17, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C# 9 Records are ignored by mpc code generator

2 participants