Skip to content

Fix mpc ignore generic type defined in out side target - #1192

Merged
AArnott merged 5 commits into
MessagePack-CSharp:masterfrom
gsino:fix_mpc_ignore_generic_type_defined_in_out_side_target
Mar 21, 2021
Merged

Fix mpc ignore generic type defined in out side target#1192
AArnott merged 5 commits into
MessagePack-CSharp:masterfrom
gsino:fix_mpc_ignore_generic_type_defined_in_out_side_target

Conversation

@gsino

@gsino gsino commented Feb 24, 2021

Copy link
Copy Markdown

fix MessagePackGenerator(mpc) and Test for #1111

Add generic type definition to TypeCollector Collect target.

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't deeply understand mpc, but this looks reasonable to me, and includes tests. Thank you, @gsino.
@neuecc can you take a look?

@AArnott
AArnott requested a review from neuecc March 18, 2021 23:31

@neuecc neuecc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of change is small, so I think it will be fine. Thanks.

@AArnott
AArnott merged commit ffc1831 into MessagePack-CSharp:master Mar 21, 2021
@gsino

gsino commented Mar 22, 2021

Copy link
Copy Markdown
Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants