Adapt CtorParameterAndPropertySetterExists test for v2.3 behavior - #1156
Merged
AArnott merged 3 commits intoJan 2, 2021
Conversation
Contributor
|
Oh, I was not aware of that this breaking change caused this situation! I introduced this breaking change in order not to set parameters twice(constructor and setter). |
Collaborator
Author
|
IMO setting them twice is wasteful and the new behavior is better. But I am less sure it is worth the behavioral change. Perhaps we can keep it for now and revert this part of your change if folks complain. |
Contributor
|
I agree with the reverting of this behaviour when folks complain it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #1155
CC: @pCYSl5EDgo who introduced this breaking change. Was the breaking change necessary for what you were delivering (#1095)?