Skip to content

Fix handling nested generic types in code generation - #1048

Merged
neuecc merged 1 commit into
MessagePack-CSharp:masterfrom
mayuki:GeneratorNestedGenericTypes
Sep 24, 2020
Merged

Fix handling nested generic types in code generation#1048
neuecc merged 1 commit into
MessagePack-CSharp:masterfrom
mayuki:GeneratorNestedGenericTypes

Conversation

@mayuki

@mayuki mayuki commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

#1010 (comment)

This PR fixes an issue where code generation for nested generic types would result in incorrect code output.

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @neuecc Can you review as well?

@neuecc

neuecc commented Sep 24, 2020

Copy link
Copy Markdown
Member

good implementations and thanks for fully covered tests.

@neuecc
neuecc merged commit 06eb6e1 into MessagePack-CSharp:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants