Conversation
MessageContainerView updates
SD10
commented
Sep 3, 2017
| return nil | ||
| case .bubble, .bubbleOutline: | ||
| break | ||
| case .bubbleTail(let edge), .bubbleTailOutline(let edge): |
SD10
commented
Sep 3, 2017
|
|
||
| cell.avatarView.set(avatar: avatar) | ||
| cell.messageLabel.textColor = textColor | ||
| cell.messageContainerView.backgroundColor = messageColor |
Member
Author
There was a problem hiding this comment.
We probably want to set this to the messageColor still if the style is .none
SD10
commented
Sep 3, 2017
| return .up | ||
| default: | ||
| fatalError("Invalid UIRectCorner. Only supports: .topLeft, .bottomLeft, .topRight, .bottomRight") | ||
| } |
Member
Author
There was a problem hiding this comment.
Not hard to replace this with an enum that will prevent this from even being a possible issue
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 77 77
=====================================
Hits 77 77
Continue to review full report at Codecov.
|
It seems as though when using a UINavigationController there is an issue with the rendering of an inputAccessoryView. This workaround creates a copy during the animation and then deletes it.
Add images for bubbles
A workaround solution for the render issue with MessageInputBar
|
@SD10 You should work on setting me up 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Renamestill can't decideMessageType->MessageRenamestill can't decideMessageData->MessageTypeMap AvatarPosition -> UIRectCorner for tail???low priorityProvide ability to move top label / bottom label inside message bubble painfulAdd shouldDisplayCellTopLabel & shouldDisplayCellBottomLabel (maybe?)too earlyCreate constants for ReusableViewIdentifiersMessagesDisplayDataSource->MessagesDisplayDelegateavatarPositiontoMessagesLayoutDelegatemessageLabelDelegateand makeMessageCellDelegateconform toMessageLabelDelegateincomingAvatarSize&outgoingAvatarSizein favor ofavatarSize(for:indexPath:)