Typing Indicator Support by nathantannar4 · Pull Request #776 · MessageKit/MessageKit

nathantannar4 · 2018-07-23T05:49:14Z

This PR adds TypingIndicator support by reserving the last section of the MessageCollectionView as needed. MessageKit will support the iMessage style typing bubble out of the box but you can also implement your own typing indicator cells!

zhongwuzw · 2018-07-23T13:36:45Z

When the indicator is animating, the same time I post a message, indicator cell would scroll to the bottom, this scroll animation is what we want?

nathantannar4 · 2018-07-23T17:46:38Z

I think that's how other messaging apps handle it

_{Sent with GitHawk}

SD10 · 2018-07-23T18:06:17Z

I'll have to check this animation you guys are talking about. This is a feature that MessageKit will support, but personally I will never use it

SD10 · 2018-08-07T04:48:10Z

+        setTypingIndicatorHidden(!isTyping, animated: true, completion: { _ in
+            self.messagesCollectionView.scrollToBottom(animated: true)
+        })
+//        defer {


This code is commented out, you planning on doing something with it?

Once this gets merged I will be updating the entire example app with more detailed examples for the TypingIndicator and custom cells.

SD10 · 2018-08-07T04:48:35Z

+    ///   - updates: A block of code that will be executed during `performBatchUpdates`
+    ///              when `animated` is `TRUE` or before the `completion` block executes
+    ///              when `animated` is `FALSE`
+    ///   - completion: A completion block to execute after the insertion/deletion


Very nice docs 💯 🥇

SD10 · 2018-08-07T04:53:59Z


 ### Added

+- **Breaking Change** Added typing indicator support to MessageKit by adding an extra section to `MessagesCollectionView` when needed. This included adding the following views: `BubbleCircle`, `TypingBubble`, `TypingIndicator`, `TypingBubbleCell`. Determine if the section is reserved for the typing indicator with `isSectionReservedForTypingIndicator(_ section: Int) -> Bool`, and set the typing indicators visiability with `setTypingIndicatorHidden(_ isHidden: Bool, animated: Bool, whilePerforming updates: (() -> Void)? = nil, completion: ((Bool) -> Void)?=nil)`


This is more a reminder to myself to improve this CHANGELOG entry before merging

I don't know how we can tell the user that numberOfSections(in collectionView: UICollectionView) would not only return the data source the user provide.

Yes, this is a valid concern that I have as well. I like the general idea but I haven't gone deep into how this will affect MessageKit

stasian23 · 2018-08-08T09:30:27Z

Hi guys, are you planning to merge it to dev, and release? We really need this feature in our project

SD10 · 2018-08-08T12:00:22Z

@stasian23 That's the plan but this is lower priority right now. I like the general idea but I haven't thoroughly reviewed the code to see what impact this PR would have

nathantannar4 · 2018-08-08T21:16:27Z

@stasian23 I just rebased thetypingBubble branch onto the development branch. You can specify in your pod file to pull from the typingBubble branch if you would like to use it in pre-release

zhongwuzw · 2018-08-09T11:19:55Z

+    ///              when `animated` is `TRUE` or before the `completion` block executes
+    ///              when `animated` is `FALSE`
+    ///   - completion: A completion block to execute after the insertion/deletion
+    open func setTypingIndicatorHidden(_ isHidden: Bool, animated: Bool, whilePerforming updates: (() -> Void)? = nil, completion: ((Bool) -> Void)?=nil) {


completion: ((Bool) -> Void)?=nil,please keep indention between nil.

zhongwuzw · 2018-08-09T11:22:26Z

+        let section = messagesCollectionView.numberOfSections
+
+        isTypingIndicatorHidden = isHidden
+        if let messagesFlowLayout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout {


Maybe guard return would be better, if layout is not MessagesCollectionViewFlowLayout, nothing we can do.

zhongwuzw · 2018-08-09T11:34:54Z


 ### Added

+- **Breaking Change** Added typing indicator support to MessageKit by adding an extra section to `MessagesCollectionView` when needed. This included adding the following views: `BubbleCircle`, `TypingBubble`, `TypingIndicator`, `TypingBubbleCell`. Determine if the section is reserved for the typing indicator with `isSectionReservedForTypingIndicator(_ section: Int) -> Bool`, and set the typing indicators visiability with `setTypingIndicatorHidden(_ isHidden: Bool, animated: Bool, whilePerforming updates: (() -> Void)? = nil, completion: ((Bool) -> Void)?=nil)`


I don't know how we can tell the user that numberOfSections(in collectionView: UICollectionView) would not only return the data source the user provide.

zhongwuzw · 2018-08-09T11:41:27Z

+            cell.typingBubble.typingIndicator.dotColor = typingBubbleDotColor
+            cell.typingBubble.startAnimating()
+            return cell
+        }


Just a suggestion, can we move these things to a separate function? collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) becomes the big function.

Yeah, it should be a function on the cell

zhongwuzw · 2018-08-09T13:21:02Z

+    }
+
+    open func setupSubviews() {
+        contentView.autoresizingMask = [.flexibleWidth, .flexibleHeight]


Is this necessary?

Thats how other MessageContentCell are set up so I added this for consistency

Don't copy my code if it's bad (it usually is) 😆

zhongwuzw · 2018-08-09T13:22:28Z

+        super.prepareForReuse()
+        if typingBubble.isAnimating {
+            typingBubble.stopAnimating()
+            typingBubble.startAnimating()


startAnimating() is not necessary IMO.

The animations stop when they move off screen, so they need to be restarted when they are about to appear again

@nathantannar4 May I miss something? you already start it in cellForItemAt. 🤔

Its required for the cell reusability. If its not initially started in cellForItem then isAnimating will be false

nathantannar4 · 2018-08-10T00:21:02Z

Recommendations added

gorbat-o · 2018-09-24T22:14:17Z

Hey,

Is there any progress on this PR ?

I hope it can be merged soon :D

nathantannar4 · 2018-09-24T23:03:19Z

2.0 release 😄

_{Sent with GitHawk}

gorbat-o · 2018-09-25T08:02:17Z

😱😱😱😱😱
When ??

nathantannar4 · 2018-10-03T18:46:05Z

@SD10 and I have had some offline discussion about this and how this method reserves the last section of the MessagesCollectionView.

@SD10 I know you mentioned reserving the last section would be an issue for RxSwift users, but is there anything else?

`dequeuedTypingCell(for indexPath: IndexPath) ` can be used for easily overriding the typing cell and keeps `collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath)` clean

nathantannar4 · 2018-10-14T21:16:25Z

Re-evaluating this PR so that is does not reserve a section

nathantannar4 · 2018-12-27T00:25:00Z

@SD10 @zhongwuzw I am revisiting this so we can get it merged. Are there still hesitations to adding an additional section? I tried using supplementary views but it becomes much more challenging to manage since the indicator ends up needing to be tied to a specific section. There are just many more edge cases that route.

SD10 · 2018-12-27T00:47:02Z

Are there still hesitations to adding an additional section?

It's been so long I'll have to re-evaluate reserving the last section for the typing indicator but I do think the highly dynamic nature of a typing indicator would cause a lot of IndexPath inconsistencies with apps in a production environment.

Probably not a good candidate for 3.0

zhongwuzw · 2018-12-27T02:01:45Z

I agree with @SD10 , can we put the indicator view as a subview of UICollectionView? not treat it as a cell.

nathantannar4 self-assigned this Jul 23, 2018

nathantannar4 added this to the 2.0 milestone Jul 23, 2018

nathantannar4 requested a review from zhongwuzw July 23, 2018 06:06

SD10 added the under review label Aug 7, 2018

SD10 reviewed Aug 7, 2018

View reviewed changes

nathantannar4 force-pushed the typingBubble branch from b978857 to df05cda Compare August 8, 2018 21:15

zhongwuzw reviewed Aug 9, 2018

View reviewed changes

nathantannar4 force-pushed the typingBubble branch from 7c6a567 to 3bc014f Compare August 26, 2018 16:57

nathantannar4 removed this from the 2.1 milestone Oct 13, 2018

nathantannar4 added 10 commits October 14, 2018 13:20

Working Prototype

e7ba9f3

Changes suggested by SD10

ffa3453

TypingIndicator API adjustments

4274765

Circle -> BubbleCircle

fd706b0

Public access, needed for custom FlowLayouts, custom cells, etc

79da8ea

API adjustments to choose TypingBubble colors with properties

5b4142d

Add CHANGELOG, rename TypingBubble -> TypingIndicator

bcbfb05

Add default backgroundColor

1f0d6a9

Smoother Animations, more like iMessage

0422590

Cleanup and added dequeuedTypingCell(for indexPath: IndexPath)

cdf7286

`dequeuedTypingCell(for indexPath: IndexPath) ` can be used for easily overriding the typing cell and keeps `collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath)` clean

nathantannar4 added 2 commits October 14, 2018 13:23

Rebase onto development

c0a889f

Update to Swift 4.2

f5bbd1a

nathantannar4 force-pushed the typingBubble branch from 5f30df7 to f5bbd1a Compare October 14, 2018 20:33

nathantannar4 force-pushed the typingBubble branch from 0ad7c25 to f5bbd1a Compare October 15, 2018 05:05

nathantannar4 mentioned this pull request Oct 15, 2018

Typing Indicator Support #911

Closed

Merge branch 'development' into typingBubble

05faf2c

nathantannar4 closed this Mar 1, 2019

nathantannar4 deleted the typingBubble branch April 25, 2019 23:03


		### Added

		- Breaking Change Added typing indicator support to MessageKit by adding an extra section to `MessagesCollectionView` when needed. This included adding the following views: `BubbleCircle`, `TypingBubble`, `TypingIndicator`, `TypingBubbleCell`. Determine if the section is reserved for the typing indicator with `isSectionReservedForTypingIndicator(_ section: Int) -> Bool`, and set the typing indicators visiability with `setTypingIndicatorHidden(_ isHidden: Bool, animated: Bool, whilePerforming updates: (() -> Void)? = nil, completion: ((Bool) -> Void)?=nil)`

Conversation

nathantannar4 commented Jul 23, 2018

Uh oh!

zhongwuzw commented Jul 23, 2018

Uh oh!

nathantannar4 commented Jul 23, 2018

Uh oh!

SD10 commented Jul 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stasian23 commented Aug 8, 2018

Uh oh!

SD10 commented Aug 8, 2018

Uh oh!

nathantannar4 commented Aug 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nathantannar4 commented Aug 10, 2018

Uh oh!

gorbat-o commented Sep 24, 2018

Uh oh!

nathantannar4 commented Sep 24, 2018

Uh oh!

gorbat-o commented Sep 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nathantannar4 commented Oct 3, 2018

Uh oh!

nathantannar4 commented Oct 14, 2018

Uh oh!

nathantannar4 commented Dec 27, 2018

Uh oh!

SD10 commented Dec 27, 2018

Uh oh!

zhongwuzw commented Dec 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gorbat-o commented Sep 25, 2018 •

edited

Loading