Skip to content

Update the README.md for using swift 3#264

Merged
SD10 merged 2 commits into
MessageKit:v0.10.0from
azurechen:patch-1
Oct 18, 2017
Merged

Update the README.md for using swift 3#264
SD10 merged 2 commits into
MessageKit:v0.10.0from
azurechen:patch-1

Conversation

@azurechen

@azurechen azurechen commented Oct 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

If the project still use swift 3. The config in MessageKit.podspec will not work.

s.pod_target_xcconfig = {
      "SWIFT_VERSION" => "4.0",
}

Add the extra post_install in Podfile will fix this issue.

post_install do |installer|
        installer.pods_project.targets.each do |target|
            if target.name == 'MessageKit'
                target.build_configurations.each do |config|
                    config.build_settings['SWIFT_VERSION'] = '4.0'
                end
            end
        end
    end

Does this close any currently open issues?

#151
#124

Where has this been tested?

Swift Version: Swift 3.2
MessageKit Version: 0.9.0

@azurechen
Update the README.md for using swift 3
341ece5 
If the project still use swift 3. The config in `MessageKit.podspec` will not work.

```
s.pod_target_xcconfig = {
      "SWIFT_VERSION" => "4.0",
}
```

Add the extra `post_install` in Podfile will fix this issue.
@azurechen
Remove ruby highlight
a783ffc
@SD10 SD10 changed the base branch from master to v0.10.0 October 18, 2017 03:17
@SD10

SD10 commented Oct 18, 2017

Copy link
Copy Markdown
Member

Thank you @azurechen 👍 💯

@SD10 SD10 merged commit 330bf06 into MessageKit:v0.10.0 Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SD10 SD10 SD10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azurechen @SD10