Skip to content

Fix MediaMessageCell’s off center play button #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SirArkimedes merged 2 commits into from
Oct 6, 2017
Merged

Fix MediaMessageCell’s off center play button #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea715ca
Fix MediaMessageCell’s off center play button
SirArkimedes Oct 6, 2017
257b4d8
Add PlayButtonView fix to Changelog
SirArkimedes Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa
- `scrollIndicatorInsets` to match the insets of the `MessagesCollectionView`.
[#174](https://github.com/MessageKit/MessageKit/pull/174) by [@etoledom](https://github.com/etoledom).

- `MediaMessageCell` had an offset `PlayButtonView` that was being constrained to the cell and not the message container.
[#239](https://github.com/MessageKit/MessageKit/pull/239) by [@SirArkimedes](https://github.com/SirArkimedes).

### Changed

- **Breaking Change** `snapshotOptionsForLocation` method is now part of `LocationMessageDisplayDelegate`.
Expand Down
4 changes: 2 additions & 2 deletions Sources/Views/Cells/MediaMessageCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ open class MediaMessageCell: MessageCollectionViewCell<UIImageView> {
private func setupConstraints() {
playButtonView.translatesAutoresizingMaskIntoConstraints = false

let centerX = playButtonView.centerXAnchor.constraint(equalTo: centerXAnchor)
let centerY = playButtonView.centerYAnchor.constraint(equalTo: centerYAnchor)
let centerX = playButtonView.centerXAnchor.constraint(equalTo: messageContainerView.centerXAnchor)
let centerY = playButtonView.centerYAnchor.constraint(equalTo: messageContainerView.centerYAnchor)
let width = playButtonView.widthAnchor.constraint(equalToConstant: playButtonView.bounds.width)
let height = playButtonView.heightAnchor.constraint(equalToConstant: playButtonView.bounds.height)

Expand Down