Update issue_template#223
Merged
Merged
Conversation
SD10
reviewed
Oct 4, 2017
|
|
||
| **Toolchain Version:** … | ||
|
|
||
| **SDK Version:** … |
Member
There was a problem hiding this comment.
Can we change this to "MessageKit Version:" ?
SD10
reviewed
Oct 4, 2017
|
|
||
| **Target Platform:** … | ||
|
|
||
| **Toolchain Version:** … |
SD10
reviewed
Oct 4, 2017
|
|
||
| Where has this been tested? | ||
| --------------------------- | ||
| **Operating System:** … |
SD10
reviewed
Oct 4, 2017
|
|
||
| **Platform:** … | ||
|
|
||
| **Target Platform:** … |
SD10
reviewed
Oct 4, 2017
| --------------------------- | ||
| **Operating System:** … | ||
|
|
||
| **Platform:** … |
SD10
requested changes
Oct 4, 2017
SD10
left a comment
SD10
left a comment
Member
There was a problem hiding this comment.
@VictorAlagwu Good work. Just a few changes to make it more specific to our project. No need for a new PR. Just make the changes with another commit.
Member
Author
|
I have done that |
Sherlouk
reviewed
Oct 4, 2017
Sherlouk
left a comment
Sherlouk
left a comment
Contributor
There was a problem hiding this comment.
Could we also move these to the .github directory as to not clog up the root directory?
Also I have mild OCPD so can we name the files consistently: issue_template.md (same) and pull_request_template.md (underscores, not hypens).
Member
Author
|
Will do that |
Member
Author
|
Done |
SD10
approved these changes
Oct 4, 2017
Member
|
Thank you @VictorAlagwu 🎉 👍 |
Member
Author
|
You are welcome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.