[Added] additionalTopContentInset property#218
Merged
Conversation
Sherlouk
reviewed
Oct 3, 2017
| [#213](https://github.com/MessageKit/MessageKit/pull/213) by [@FraDeliro](https://github.com/FraDeliro). | ||
|
|
||
| - `additionalTopContentInset` property to `MessagesColectionViewController` to allow users to account for extra subviews. | ||
| [#218](https://github.com/MessageKit/MessageKit/pull/213) by [@SD10](https://github.com/SD10). |
Contributor
There was a problem hiding this comment.
Wrong PR number in link! Amateur hour over here
Member
Author
There was a problem hiding this comment.
Brutal. I tried to make the CHANGELOG entry before the PR this time
Contributor
There was a problem hiding this comment.
😂 #savedACommit is this the new trend?
Otherwise looks good though!
Member
Author
There was a problem hiding this comment.
I'm trying to hide the mistake in the git history 😅 GO BACK TO WORK!
I'm uninstalling SherloukLint
SD10
force-pushed
the
enhancement/additional-inset
branch
from
8b97240 to
e8ea044
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some background around this. I wanted to get away from managing the
topinset ofMessagesCollectionViewto allow users to add subviews on top of the view and account for their size. However, this is the only way to support allowing the messages to scroll under a translucent nav bar.#117