Added custom animation support for displaying map on location messages.#210
Conversation
| /// - indexPath: Message's index path | ||
| /// - messagesCollectionView: The collection view requesting the information | ||
| /// - Returns: Your customized animation block. | ||
| func animationBlockForLocation(message: MessageType, at indexPath: IndexPath, in messagesCollectionView: MessagesCollectionView) -> ((UIView) -> Void)? |
There was a problem hiding this comment.
I think that the LocationMessageCells ContentView is a UIImageView and not a UIView? We may want to represent this in the block
There was a problem hiding this comment.
Sure! I will change that 🙂
|
@etoledom We also need a CHANGELOG entry following the same guidelines we are using in This would go under the |
Added entry on Changelog.
| - `messageLabelInsets(for:indexPath:messagesCollectionView` method to `MessagesLayoutDelegate`. | ||
| [#162](https://github.com/MessageKit/MessageKit/pull/162) by [@SD10](https://github.com/SD10). | ||
|
|
||
| -`animationBlockForLocation(message:indexPath:messagesCollectionView)` method to `LocationMessageDisplayDelegate` to customize the display animation of the location message's map |
There was a problem hiding this comment.
- Can you add a space so we have a proper bullet point? 😉
- Can you end every sentence with a period? 😂
- Can you mark the PR number with the
#character?
Very nitty, I can change them after merge if you'd like. I will add these things to the CHANGELOG guidelines as well.
There was a problem hiding this comment.
I will change them, don't worry. Is good to not forget later on 😁
…n is working on the example app.
| view.layer.transform = CATransform3DIdentity | ||
| view.alpha = 1.0 | ||
| }, completion: nil) | ||
| } |
There was a problem hiding this comment.
We may change this default animation but merging for now!
2 participants
No description provided.