Swift 4 support#151
Merged
Merged
Conversation
Member
|
@Sepho Thanks for taking the initiative to start this. Looks like we have a build error |
Contributor
Author
|
Hi Steven,
Main project built fine for me, but on example project I had to change swift version from 3.2 to 4 on project build settings
El 23 sept 2017 21:17 +0200, Steven Deutsch <notifications@github.com>, escribió:
… @Sepho Thanks for taking the initiative to start this. Looks like we have a build error
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
@Sepho Thanks. I just forgot to update the Xcode version on CI |
SD10
approved these changes
Sep 24, 2017
Member
|
@Sepho Thank you for your contribution 👍 💯 I've invited you to join the MessageKit organization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update main and example projects to Xcode 9 and swift 4 support