Issue #129#135
Closed
nathantannar4 wants to merge 2 commits into
Closed
Conversation
I noticed that since viewDidAppear can be called more than once during a views life cycle we dont want to add a copy of the MessageInputBar to the view after is has already been correctly rendered. I just added a flag to account for this edge case. To see an example of the bug, present a UIAlertController in MessagesViewController and a copy of the MessageInputBar gets incorrectly added.
SD10
reviewed
Sep 19, 2017
| } | ||
|
|
||
| open func textViewDidChange() { | ||
| let trimmedText = inputTextView.text.trimmingCharacters(in: .whitespacesAndNewlines) |
Member
There was a problem hiding this comment.
Was it necessary to remove this? I like how the send button is enabled/disabled by taking into account if a message only contains white space
Codecov Report
@@ Coverage Diff @@
## v0.8.0 #135 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 77 77
=====================================
Hits 77 77Continue to review full report at Codecov.
|
Member
|
@nathantannar4 I'm going to close this because it doesn't fix the issue and it changes the functionality around enabling/disabling the send button |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.