Skip to content

Supporting Media Messages#126

Merged
SD10 merged 19 commits into
v0.8.0from
enhancement/media-messages
Sep 21, 2017
Merged

Supporting Media Messages#126
SD10 merged 19 commits into
v0.8.0from
enhancement/media-messages

Conversation

@SD10

@SD10 SD10 commented Sep 15, 2017

Copy link
Copy Markdown
Member

Summary

  • We make MessageCollectionViewCell generic over its messageContentView
  • We subclass MessageCollectionViewCell for specific message types and satisfy the generic
    Ex) TextMessageCell: MessageCollectionViewCell<MessageLabel>

Most of this groundwork was stolen from @Sherlouk 😁

It's a bit rough right now, I just like working with a pull request open to review the diffs.

TODO:

  • Photo Message
  • Video Message
  • Location Message

@codecov-io

codecov-io commented Sep 16, 2017

Copy link
Copy Markdown

Codecov Report

Merging #126 into v0.8.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           v0.8.0   #126   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          77     77           
=====================================
  Hits           77     77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db61882...d364454. Read the comment docs.

@SD10 SD10 changed the title [WIP] Supporting Media Messages Supporting Media Messages Sep 20, 2017
@SD10 SD10 merged commit 059bbdc into v0.8.0 Sep 21, 2017
@SD10 SD10 deleted the enhancement/media-messages branch September 21, 2017 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants