Skip to content

Typing Indicator Support#1038

Merged
nathantannar4 merged 16 commits into
3.0.0-betafrom
typingIndicatorView
Apr 5, 2019
Merged

Typing Indicator Support#1038
nathantannar4 merged 16 commits into
3.0.0-betafrom
typingIndicatorView

Conversation

@nathantannar4

Copy link
Copy Markdown
Member

Fresh PR continuing the work from #911

This was referenced Apr 3, 2019
@ahmedAlmasri

Copy link
Copy Markdown

@nathantannar4 it's working fine , But i have a question

there are the two typing functions the one it's showing typing view and other not show

call direct func from MessagesViewController class like this
setTypingIndicatorViewHidden(!isTyping, animated: true) it's showing typing view

call from collection view like this self.messagesCollectionView.setTypingIndicatorViewHidden(!isTyping) typing view not showing

@nathantannar4

Copy link
Copy Markdown
Member Author

@ahmedAlmasri great point, I should restrict the access control so it cannot be called on the MessagesCollectionView

Sent with GitHawk

@nathantannar4 nathantannar4 merged commit 4e6250f into 3.0.0-beta Apr 5, 2019
@nathantannar4 nathantannar4 deleted the typingIndicatorView branch April 25, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants