Add support for share contact message#1013
Merged
Merged
Conversation
…are_contact # Conflicts: # Example/Sources/Data Generation/SampleData.swift # Sources/Views/Cells/AudioMessageCell.swift
Contributor
Author
|
I don't know why CircleCi it complains about not founding MessageInputBar. |
Member
|
Ya ignore circle for now I haven't set it up right for the dependency changes. This looks promising! Will for sure include in 3.0. Busy right now but I'll take a look soon Sent with GitHawk |
nathantannar4
left a comment
nathantannar4
left a comment
Member
There was a problem hiding this comment.
Just looked over the code. Haven't tested yet.
4 tasks
…into share_contact # Conflicts: # Example/Sources/Data Generation/SampleData.swift
Member
|
@moldovaniosif You have some build errors with the functions you are using to setup constraints |
nathantannar4
left a comment
nathantannar4
left a comment
Member
There was a problem hiding this comment.
Please be careful merging in other branches to yours. It looks like you merged in the master branch (or started from) and this thus reverts changes made in the 3.0.0-beta branch
Contributor
Author
|
The merge with mater was a mistake, I reverted those commits. |
nathantannar4
approved these changes
Apr 5, 2019
| /// contact last name | ||
| var lastName: String? { get } | ||
| /// initials from contact first and last name | ||
| var initials: String { get } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
It add support for share contact message. It implements UI for the share contact cell.
Does this close any currently open issues?
NO
Where has this been tested?
Devices/Simulators: … iPhone XS Simulator, iPhone XS device
iOS Version: …. 12.1.4
Swift Version: …. 4.2
MessageKit Version: …. 3.0.0 beta
Share contact cell UI:
