Skip to content

Wire event memory#1304

Closed
edwinyyyu wants to merge 1 commit into
MemMachine:mainfrom
edwinyyyu:wire_event_memory
Closed

Wire event memory#1304
edwinyyyu wants to merge 1 commit into
MemMachine:mainfrom
edwinyyyu:wire_event_memory

Conversation

@edwinyyyu
Copy link
Copy Markdown
Contributor

@edwinyyyu edwinyyyu commented Apr 7, 2026

Purpose of the change

Wiring in separate PR to separate concerns for review

Description

Based on #1199/#1205

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

[Please delete options that are not relevant.]

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu edwinyyyu marked this pull request as draft April 7, 2026 16:57
@edwinyyyu edwinyyyu added this to the v0.3.5 milestone Apr 7, 2026
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 2 times, most recently from 8da380b to e5bef6b Compare April 7, 2026 18:48
@edwinyyyu edwinyyyu modified the milestones: v0.3.5, v0.4.0 Apr 7, 2026
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 6 times, most recently from bcb0516 to 5b59694 Compare April 10, 2026 16:49
@edwinyyyu edwinyyyu marked this pull request as ready for review April 10, 2026 19:09
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 4 times, most recently from f794e36 to 51517cb Compare April 17, 2026 05:19
@edwinyyyu
Copy link
Copy Markdown
Contributor Author

edwinyyyu commented Apr 21, 2026

2k LoC for wiring is too much.

@edwinyyyu edwinyyyu marked this pull request as draft April 21, 2026 23:03
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 4 times, most recently from ed62d85 to e0ee588 Compare April 27, 2026 21:05
@edwinyyyu edwinyyyu marked this pull request as ready for review April 27, 2026 23:35
@edwinyyyu edwinyyyu marked this pull request as draft April 27, 2026 23:35
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 4 times, most recently from 4372a37 to dffd951 Compare April 29, 2026 00:13
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch from dffd951 to 8255cae Compare May 4, 2026 17:09
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 6 times, most recently from 5c8f30f to 21c2500 Compare May 8, 2026 17:29
@edwinyyyu edwinyyyu marked this pull request as ready for review May 8, 2026 17:29
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch 2 times, most recently from 79a2fbf to f99d386 Compare May 8, 2026 17:54
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Attempt fix

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

New parameters

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Update

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Update formatting wiring

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Wiring for date and time format decoupling

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Add new query result formatters

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Context fields may expose sensitive information if used in filtering

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Update wiring

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Update

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Update

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Update

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Fix rebase

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Wire SQLAlchemySegmentStore

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

Fix wiring

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu force-pushed the wire_event_memory branch from f99d386 to 6a2ab75 Compare May 8, 2026 20:49
@edwinyyyu edwinyyyu marked this pull request as draft May 8, 2026 21:51
@edwinyyyu edwinyyyu closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant