Open
Conversation
Add mem-machine charts for k8s deploy.
sscargal
requested changes
Jan 30, 2026
Contributor
sscargal
left a comment
sscargal
left a comment
There was a problem hiding this comment.
The charts are fine and easily approved.
My feedback and request are to consider how users will use this. For example, rather than deployments/charts, perhaps deployments/helm or deployments/HelmCharts. This allows us to add other deployment methods in the future, such as AWS CloudFormation (deployments/AWS/CloudFormation), for example.
Additionally, I'd like to see instructions in the README.md describing what these scripts do, an explanation of the directory structure, a brief comment on each file, and instructions on how to use this Helm Chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mem-machine charts for k8s deploy.
Purpose of the change
Add helm charts to deploy mem-machine into k8s.
Description
Implement helm charts which can be used to deploy mem-machine into k8s/k3s
Fixes/Closes
Fixes #1006
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Results: [Attach logs, screenshots, or relevant output]
Checklist
Maintainer Checklist
Screenshots/Gifs
N/A
Further comments
None