You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Issue compiling on Arch Linux with python 3.13 #245
Hi, I'm the AUR maintainer of pythonqt-git on AUR, with the update to Python 3.13.1 in the Arch Linux repository I have tried to rebuild the program, there is this issue; the same is happening for the last stable version 3.5.6
PythonQt.cpp: In constructor 'PythonQt::PythonQt(int, const QByteArray&)':
PythonQt.cpp:352:8: error: 'PyEval_ThreadsInitialized' was not declared in this scope; did you mean 'PythonAlreadyInitialized'?
352 | if (!PyEval_ThreadsInitialized()) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| PythonAlreadyInitialized
Thanks! A bit of googling shows that this has indeed been removed.
From the Python 3.13 release notes:
Remove the PyEval_ThreadsInitialized() function, deprecated in Python 3.9. Since Python 3.7, Py_Initialize() always creates the GIL: calling PyEval_InitThreads() does nothing and PyEval_ThreadsInitialized() always returns non-zero.
So this check can savely be removed from the code.
Activity
mrbean-bremen commentedon Dec 28, 2024
Thanks! A bit of googling shows that this has indeed been removed.
From the Python 3.13 release notes:
So this check can savely be removed from the code.
FabioLolix commentedon Dec 28, 2024
OK, I have removed the whole
and builded again, can I make the PR?
mrbean-bremen commentedon Dec 28, 2024
Of course, go ahead!
mrbean-bremen commentedon Dec 28, 2024
Maybe it also makes sense to add a Python 3.13 build to the CI - the OS does not really matter.
mrbean-bremen commentedon Dec 28, 2024
@FabioLolix - do you need a patch release?
FabioLolix commentedon Dec 28, 2024
pythonqt-git doesn't really need it because it pull the latest commit at build time but I'm sure other packagers will appreciate
mrbean-bremen commentedon Dec 28, 2024
Ok, thanks!
Fix build with Python 3.13 (MeVisLab#246)
Fix build with Python 3.13 (MeVisLab#246)