refactor(bigquery): update code samples and move to own sample file #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Whoa, it's too many changes. We agreed with Tim Swast, that we'll be pushing the samples in portions: five samples per PR |
Collaborator
Author
|
@IlyaFaer ok sure i will do that. |
mf2199
requested changes
Jan 20, 2020
Collaborator
mf2199
left a comment
mf2199
left a comment
There was a problem hiding this comment.
Looks good overall. Are you doing this by hand or using a script?
| # limitations under the License. | ||
|
|
||
| import os | ||
| from google.cloud import bigquery |
Collaborator
There was a problem hiding this comment.
Either, add a blank line here or remove blank lines elsewhere to maintain formatting consistency.
Collaborator
Author
There was a problem hiding this comment.
@mf2199 By hand as need to change few things and also have to add few assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards [8989]
List of changes:
New samples: