Skip to content

fix(firestore): fix get and getall method of transaction #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
HemangChothani wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(firestore): fix get and getall method of transaction #96

HemangChothani wants to merge 1 commit into from

Conversation

@HemangChothani
Copy link
Collaborator

@HemangChothani HemangChothani commented Jan 9, 2020 •
edited by IlyaFaer
Loading

IPR 10078

mf2199
mf2199 approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also post a brief description of the issue root cause and why it's transaction.py and not _helpers.py that have to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IlyaFaer IlyaFaer IlyaFaer approved these changes

@mf2199 mf2199 mf2199 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HemangChothani @IlyaFaer @mf2199