[GCP-8695] Adding validation checkpoints inside batch() and snapshot() methods. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
approved these changes
Jul 25, 2019
emar-kar
approved these changes
Jul 25, 2019
mf2199
changed the title
sumit-ql
reviewed
Aug 2, 2019
|
I think we need to add some test coverage around _validate() method, otherwise nox session "cover" will fail with coverage less than 100% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses googleapis#8695.
The observed error
400 Invalid CreateSession requestis thrown when theSnapshotCheckout()linesession = self._session = self._database._pool.get()invokesBurstyPool.get()that tries to create a session under an obviously non-existing instance. The proposed way of solving it puts a conditional "check-point" statement just before constructing theSnapshotCheckout()object.Since the
BatchCheckout()class does exactly the same, the above may apply to theDatabase.batch()factory too. If so, it makes sense to encapsulate the conditional statement in a private helper function, to be called within each of the two factories.