fix(bigquery): fix start index with page size for list rows #107
Conversation
IlyaFaer
left a comment
IlyaFaer
left a comment
There was a problem hiding this comment.
Duplicate line should be deleted, other comments are not much of a major
| self._preserve_order = False | ||
| self._project = client.project | ||
| self._schema = schema | ||
| self._schema = schema |
| params = self._get_query_params() | ||
| if self._page_size is not None: | ||
| if self.page_number != 0 and "startIndex" in params: | ||
| del params["startIndex"] |
There was a problem hiding this comment.
I think, we could write if self.page_number instead of if self.page_number != 0. Page number is not gonna be negative, so this if-statement will be giving True in all cases except self.page_number == 0. And it's little bit shorter.
There was a problem hiding this comment.
Here I need to delete startIndex from query parameter after first request so when first request hit at that time page_num is 0 and after it increments so except page 0 need to delete for every request.
| {"f": [{"v": "Wylma Phlyntstone"}]}, | ||
| {"f": [{"v": "Bhettye Rhubble"}]}, | ||
| ], | ||
| } |
There was a problem hiding this comment.
page_1 and page_2 are constants, I believe
There was a problem hiding this comment.
yes this is the response with pages.
bigquery/tests/unit/test_client.py
Outdated
| self.assertEqual(rows[1], Row(("Bharney Rhubble",), f2i)) | ||
|
|
||
| second_page = six.next(pages) | ||
| rows = list(second_page) |
There was a problem hiding this comment.
I would write in this way:
rows = list(six.next(pages))
As second_page var looks excess
IPR [10184]