[GCP-5388] Storage: Blob.exists() does not work within Batch context #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
commented
Jul 1, 2019
IlyaFaer
commented
Jul 1, 2019
IlyaFaer
commented
Jul 1, 2019
IlyaFaer
commented
Jul 1, 2019
IlyaFaer
commented
Jul 1, 2019
IlyaFaer
changed the title
mf2199
approved these changes
Jul 9, 2019
mf2199
changed the title
|
Overall, solution looks good, just couple of comments related to test coverage:
|
sumit-ql
reviewed
Aug 3, 2019
| os.path.join("docs", ""), | ||
| os.path.join("docs", "_build", "html", ""), | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Is there any changes in nox file, if not, please remove this file from the the PR.
emar-kar
approved these changes
Aug 5, 2019
emar-kar
left a comment
emar-kar
left a comment
There was a problem hiding this comment.
LGTM.
Checked noxfile chgs and as I see there was a correction to pass black session.
sumit-ql
approved these changes
Aug 5, 2019
Collaborator
@emar-kar You probably meant, |
Collaborator
Author
|
@mf2199, @emar-kar, @sumit-ql, I think we have some problems with our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPR: 5388
Not very beautiful (that's how I see), but looks like it's the only easy solution. For now,
exists()don't do requests while in batch context. It only adds request into list, which will be processed on exiting batch context. Soexists()returnsTrueafter adding request into batch list, but it doesn't wait for requests to be processed. I've added object to pass it as target object into request (it will bind future request to this object) and to get result after exiting context